Fix fault injection and assertion issues in customer workflow tests (PR #49568 review)#49569
Draft
Copilot wants to merge 2 commits into
Draft
Fix fault injection and assertion issues in customer workflow tests (PR #49568 review)#49569Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
- Fix configureResponseDelayRule to use currentFaultInjectionConnectionType() instead of hard-coded DIRECT in CustomerWorkflowTestBase - Fix assertKeywordIdentifier to use containsExactlyInAnyOrder for Set<String> - Remove unused HashSet import from CustomerWorkflowChangeFeedProcessorTest - Replace magic HTTP status numbers with HttpConstants.StatusCodes.* in CustomerWorkflowRequestOptionsTest Co-authored-by: FabianMeiswinkel <19165014+FabianMeiswinkel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix fault injection and assertion issues in customer workflow tests (PR #49568 review)
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 7 unresolved review comments from PR #49568 across three test files in the new customer workflow test suite.
CustomerWorkflowTestBaseconfigureResponseDelayRule: Was hard-codingFaultInjectionConnectionType.DIRECT, so response-delay fault rules never matched gateway requests. Changed tocurrentFaultInjectionConnectionType()(mirrors the existing fix already applied toconfigureServerErrorRule).assertKeywordIdentifier:getKeywordIdentifiers()returnsSet<String>(unordered), but the assertion usedcontainsExactly()which is order-sensitive and flaky. Changed tocontainsExactlyInAnyOrder()— order-insensitive while still enforcing no unexpected additional elements.CustomerWorkflowChangeFeedProcessorTestimport java.util.HashSet.CustomerWorkflowRequestOptionsTest201,200,204) withHttpConstants.StatusCodes.CREATED,HttpConstants.StatusCodes.OK, andHttpConstants.StatusCodes.NO_CONTENTfor consistency with the rest of the Cosmos test suite. Added the corresponding import.